Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add initial port of Node.js Compat Streams #418

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 3, 2023

While there is still a lot to do here to finish up adding tests, adding the Web streams adapters, and implementing the utility consumers, this PR is already rather large at 7700+ lines changed. It's still gated as experimental so I'll iterate on this to take care of the remaining todos in a separate PR.

Derived from: https://github.com/nodejs/readable-stream

TODO:

@jasnell jasnell marked this pull request as draft March 3, 2023 21:21
@jasnell jasnell changed the title Add initial port of Node.js Compat Streams [WIP] Add initial port of Node.js Compat Streams Mar 3, 2023
@jasnell jasnell force-pushed the jsnell/nodejs-compat-streams branch from 601b3f9 to 6ec6873 Compare March 3, 2023 21:57
@jasnell jasnell force-pushed the jsnell/nodejs-compat-streams branch 3 times, most recently from 8dc7726 to 098fdde Compare March 14, 2023 15:21
@jasnell jasnell changed the title [WIP] Add initial port of Node.js Compat Streams Add initial port of Node.js Compat Streams Mar 14, 2023
@jasnell jasnell marked this pull request as ready for review March 14, 2023 16:05
Copy link
Contributor

@mikea mikea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with couple nits in C++ code.

I didn't really review .js since I suppose it comes mostly from node.

src/workerd/jsg/modules.c++ Outdated Show resolved Hide resolved
src/workerd/jsg/modules.c++ Outdated Show resolved Hide resolved
src/workerd/jsg/modules.c++ Outdated Show resolved Hide resolved
src/node/_stream_duplex.js Show resolved Hide resolved
@jasnell jasnell force-pushed the jsnell/nodejs-compat-streams branch from 098fdde to 2e8e7b6 Compare March 14, 2023 18:06
@jasnell jasnell merged commit 412a687 into main Mar 14, 2023
@fhanau fhanau deleted the jsnell/nodejs-compat-streams branch December 4, 2023 22:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants