Fixup cf types
#438
Merged
Fixup cf types
#438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbbot
force-pushed
the
bcoll/allow-unknown-cf-types
branch
from
0281949 to
763cb21
Compare
|
It may be worth adding #397 to this PR as well. That way |
- Type `Request#cf` based on type parameter, allowing `Request` construction with `RequestInitCfProperties` - Make `RequestInitCfProperties` and `IncomingRequestCfProperties` extend `Record<string, unknown>`, allowing incoming requests to be passed directly to fetch, and custom properties to added when making requests to service bindings - Make all `IncomingRequestCfPropertiesGeographicInformation` fields optional, making it easier to access `cf` geo-properties whilst still maintaining correctness Closes #324
mrbbot
force-pushed
the
bcoll/allow-unknown-cf-types
branch
from
763cb21 to
7dc9dc0
Compare
5 tasks
penalosa
approved these changes
Mar 21, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request#cfbased on type parameter, allowingRequestconstruction withRequestInitCfPropertiesRequestInitCfPropertiesandIncomingRequestCfPropertiesextendRecord<string, unknown>, allowing incoming requests to be passed directly to fetch, and custom properties to added when making requests to service bindingsIncomingRequestCfPropertiesGeographicInformationfields optional, making it easier to accesscfgeo-properties whilst still maintaining correctnessCloses #324
Closes #397