Even more streams tests #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/nodejs-streams-tests-moar
branch
from
e5028ea to
deb214e
Compare
jasnell
force-pushed
the
jsnell/nodejs-streams-tests-moar
branch
from
13e16a6 to
5bfc864
Compare
mikea
approved these changes
Mar 27, 2023
Warfields
reviewed
Mar 27, 2023
| } | ||
| return true; | ||
| }) | ||
| await rejects(stream.map((x) => x + x).toArray(), /boom/); |
There was a problem hiding this comment.
Not too sure on the expected behavior of streams, do we want to check if the error occurs on the third stream object to make sure that things happen in the right order? Similarly, on the async case.
| { | ||
| // Test result is a Readable | ||
| const stream = Readable.from([1, 2, 3, 4, 5]).filter((x) => true); | ||
| strictEqual(stream.readable, true); |
There was a problem hiding this comment.
Testing the negative case may be valuable here. Ex. testing strictEqual(stream.readable, false) when it is not safe to call read()
| strictEqual(source._readableState.pipes[1], dest2); | ||
| strictEqual(source._readableState.pipes.length, 2); | ||
|
|
||
| // Should be able to unpipe them in the reverse order that they were piped. |
There was a problem hiding this comment.
What should happen if we don't unpipe them in order?
| } | ||
| }; | ||
|
|
||
| export const pipeMultiplePipes = { |
There was a problem hiding this comment.
Currently this test is doing the following
┌────────┐
┌────────►│Writable│
│ └────────┘
│
┌───┴─────┐ ┌────────┐
│Readable ├──►│Writable│
└───┬─────┘ └────────┘
│
│ ┌────────┐
└────────►│Writable│
└────────┘
Still going through this PR, but it so far does not have a test for long chains of piped streams.
┌─────────┐ ┌──────┐ ┌──────┐ ... ┌──────┐
│Readable ├─►│Duplex├─►│Duplex├─────►│Duplex│
└─────────┘ └──────┘ └──────┘ └──────┘
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.