Fix Socket's WorkerInterface Lifetime #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warfields
force-pushed
the
swarfield/socket-lifetimes
branch
from
f8ec874 to
83fab08
Compare
In long lived actors it is possible that the promise provided by `connect()` can outlive the WorkerInterface that is used to create it's http client. this can lead to unexpected Segfaults when the socket is deconstructed. The object returned by `kj::newHttpClient(HttpService& service)` does not take ownership of the underlying HttpService, whereas asHttpClient() does. This way the WorkerInterface providing the HttpClient will live for the length of the promise. This also done for the equivalent client in the `fetch()` implementation for WebSockets.
Warfields
force-pushed
the
swarfield/socket-lifetimes
branch
from
83fab08 to
c760667
Compare
harrishancock
approved these changes
Mar 22, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In long lived actors it is possible that the promise provided by
connect()can outlive the WorkerInterface that is used to create it's http client. this can lead to unexpected Segfaults when the socket is deconstructed.The object returned by
kj::newHttpClient(HttpService& service)does not take ownership of the underlying HttpService, whereas asHttpClient() does. This way the WorkerInterface providing the HttpClient will live for the length of the promise.This also done for the equivalent client in the
fetch()implementation for WebSockets.