Implement backpressure signaling for IdentityTransformStream writable #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
commented
Mar 23, 2023
jasnell
force-pushed
the
jsnell/identitytransformstream-backpressure
branch
2 times, most recently
from
72bb232 to
242dae6
Compare
harrishancock
approved these changes
Mar 24, 2023
jasnell
force-pushed
the
jsnell/identitytransformstream-backpressure
branch
from
242dae6 to
857d9b1
Compare
Enables optional use of writer.desiredSize/writer.ready for backpressure signaling with IdentityTransformStream and FixedLengthStream.
jasnell
force-pushed
the
jsnell/identitytransformstream-backpressure
branch
from
857d9b1 to
c939220
Compare
|
@mrbbot ... just FYI on here... this change may need to be picked up by miniflare. See the included test for examples on the api change. |
|
Thanks for the heads up! 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables optional use of writer.desiredSize/writer.ready for backpressure signaling with IdentityTransformStream and FixedLengthStream. See included test for example use.