Macros to periodically warn #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace existing call sites that are basically just calling the same thing without a macro.
And their conditional variants.
vlovich
force-pushed
the
vlovich/warn-periodically-macro
branch
from
59d9d63 to
0fe3b9e
Compare
bcaimano
reviewed
Mar 29, 2023
bcaimano
reviewed
Mar 29, 2023
bcaimano
approved these changes
Mar 30, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was at it, I decided to cleanup some spots where we weren't using
JSG_WARN_ONCE. I also improved thosemacros to accept a variadic number of macro args (btw I noticed
LOG_IF_INTERESTINGandLOG_NOSENTRYmay be misusing__VA_ARGS__in the 0 variadic args case - missing a##but I decided not to touch them to avoid scope creep).I seem to have lost permission to the main workerd repo so I've forked for now until I figure out how to restore.
Hmm... bugs.ew-test is failing when I migrate
in edgeworker.c++ for some reason. The error gets printed in the logs but doesn't match the
@LOGtest directive. Hmm...