Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bazel: extract wd_ts_bundle rule to reduce boilerplate #497

Merged
merged 1 commit into from
Apr 3, 2023
Merged

bazel: extract wd_ts_bundle rule to reduce boilerplate #497

merged 1 commit into from
Apr 3, 2023

Conversation

mikea
Copy link
Collaborator

@mikea mikea commented Mar 31, 2023

No description provided.

@mikea mikea requested review from edevil and jasnell March 31, 2023 17:11
jasnell
jasnell approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a rubber-stamp LGTM as I'm still not 100% up to speed on bazel.

@mikea mikea force-pushed the maizatskyi/2023-03-31-ts_bundle branch from 8ec0934 to 612cc04 Compare April 3, 2023 15:55
@mikea mikea force-pushed the maizatskyi/2023-03-31-ts_bundle branch from 612cc04 to 749380d Compare April 3, 2023 16:48
@mikea mikea merged commit 1acd39d into main Apr 3, 2023
@mikea mikea deleted the maizatskyi/2023-03-31-ts_bundle branch April 3, 2023 17:32
kentonv pushed a commit that referenced this pull request Apr 8, 2023
@mikea @kentonv
bazel: extract wd_ts_bundle rule to reduce boilerplate (#497)
7c20dd5
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@edevil edevil Awaiting requested review from edevil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikea @jasnell