Provide Crypto/Compression API errors where safe, fix macOS compiler warning #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
force-pushed
the
felix/warn_if-refactor
branch
from
3f138a8 to
0cb88db
Compare
|
It now looks like there are cases where throwing the compression API error would cause issues, I have removed that part so now it's just Web Crypto related changes. |
jasnell
approved these changes
Apr 15, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the
JSG_WARN_ONCE_IF()statements added in recent changes to the Web Crypto/Compression Streams APIs, errors can be thrown without breaking existing code in several but not all situations where there should be an error.As a first step, throw errors where we can safely do so, which simplifies the code in several spaces; a future PR will create configuration flags to return errors in the other cases without breaking existing code.
Also fix a compiler warning about an unused variable that occurs in the implementation of FileWatcher for macOS/BSD.
Also see the eponymous upstream branch.