Add compilation fix for zlib #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Later xcode toolchains fail to compile zlib under bazel. This change adds a workaround based on bazelbuild/bazel#17956. Without this change, zlib compilation generates errors like: external/zlib/gzread.c:35:15: error: call to undeclared function 'read'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] Test: bazel build @zlib//:zlib Test: bazel build //...
ohodson
force-pushed
the
orion-bazel-6.1.1-osx-zlib-compilation
branch
from
4d9a17a to
7f2aff8
Compare
fhanau
approved these changes
Apr 10, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Later xcode toolchains fail to compile zlib under bazel. This change adds a workaround based on bazelbuild/bazel#17956.
Without this change, zlib compilation generates errors like: external/zlib/gzread.c:35:15: error: call to undeclared function 'read'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
Test: bazel build @zlib//:zlib