New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix use-after-move #552

Merged

mikea merged 1 commit into main from maizatskyi/2023-04-19-fix-use-after-move

Apr 19, 2023

Contributor

mikea commented Apr 19, 2023

as it is written now hash will always be computed of an empty string.


          fix use-after-move

389c973

as it is written now hash will always be computed of an empty string.

mikea requested review from jasnell and kentonv

April 19, 2023 21:14

jasnell approved these changes

View reviewed changes

mikea merged commit 5d64b05 into main

mikea deleted the maizatskyi/2023-04-19-fix-use-after-move branch

April 19, 2023 22:09

Member

kentonv commented Apr 19, 2023

Looks like Name::hash isn't actually used, we could delete it. (As-is it's not very useful since there's no corresponding operator==.)

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet