Node compat: Implement crypto primes #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Apr 20, 2023
jasnell
reviewed
Apr 20, 2023
jasnell
reviewed
Apr 20, 2023
jasnell
reviewed
Apr 20, 2023
jasnell
reviewed
Apr 20, 2023
jasnell
reviewed
Apr 20, 2023
jasnell
reviewed
Apr 20, 2023
jasnell
reviewed
Apr 20, 2023
jasnell
reviewed
Apr 24, 2023
jasnell
reviewed
Apr 26, 2023
jasnell
reviewed
Apr 26, 2023
fhanau
force-pushed
the
felix/node-crypto-prime
branch
from
00fb6e0 to
0f0094c
Compare
jasnell
reviewed
May 3, 2023
jasnell
reviewed
May 3, 2023
jasnell
reviewed
May 3, 2023
jasnell
reviewed
May 3, 2023
jasnell
reviewed
May 3, 2023
jasnell
reviewed
May 3, 2023
jasnell
reviewed
May 3, 2023
jasnell
reviewed
May 3, 2023
jasnell
reviewed
May 3, 2023
jasnell
reviewed
May 3, 2023
jasnell
reviewed
May 3, 2023
jasnell
reviewed
May 3, 2023
jasnell
reviewed
May 3, 2023
jasnell
force-pushed
the
felix/node-crypto-prime
branch
from
509b2fb to
66e327c
Compare
fhanau
changed the title
jasnell
approved these changes
May 5, 2023
fhanau
force-pushed
the
felix/node-crypto-prime
branch
2 times, most recently
from
de6cc07 to
e4a152d
Compare
fhanau
force-pushed
the
felix/node-crypto-prime
branch
from
e4a152d to
fe210af
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to amend this PR once the other prime functions are done, just wanted to float it now to see if there's any issues with the overall approach. Tests are not included yet as most checkPrime tests depend on generatePrime, but the few tests I looked at all passed.