Simplify Windows setup and build #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohodson
force-pushed
the
orion-windows-tweaks
branch
2 times, most recently
from
afdff92 to
7e41d9c
Compare
jasnell
approved these changes
Apr 24, 2023
ohodson
force-pushed
the
orion-windows-tweaks
branch
2 times, most recently
from
fab5ef9 to
b5dcfb0
Compare
mrbbot
reviewed
Apr 25, 2023
ohodson
force-pushed
the
orion-windows-tweaks
branch
from
b5dcfb0 to
5226ae5
Compare
Assorted changes to try to make setup and build on Windows simpler. * Adds an installer script for the workerd's dependencies on Windows (tools/windows/install-deps.bat). * Adds a command-line environment script to set up environment variables for building on Windows (tools/bazel-env.bat). * Adds vscode settings to simplify setup on Windows. * Defines BAZEL_WINSDK_FULL_VERSION and BAZEL_VC explicitly to address issues when the Windows machine has multiple versions of Visual Studio and/or the Windows SDK installed.
Adds config to use the Visual Studio debugger on Windows.
ohodson
force-pushed
the
orion-windows-tweaks
branch
from
5226ae5 to
927addc
Compare
|
You can run There's no magic for other users, e.g. if someone has installed dependencies manually and then running the script shouldn't affect those. It's generally quite annoying that the installed bits can't be better isolated from the rest of Windows, but it was ever thus. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted changes to try to make setup and build on Windows simpler.