Add node.js compat streams split2 example #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohodson
reviewed
May 4, 2023
ohodson
reviewed
May 4, 2023
ohodson
reviewed
May 4, 2023
jasnell
commented
May 4, 2023
jasnell
commented
May 4, 2023
jasnell
commented
May 4, 2023
The split2 module is downloaded over 13 million times per week and has over 1000 dependent modules. It is a good example of a simple utility that previously could not be run within workers without also bundling a complex and large polyfill of the streams API. Now, however, it can be run directly within a worker without any modifications and without any additional polyfills.
jasnell
force-pushed
the
jsnell/add-nodejs-compat-streams-split2-example
branch
from
015043f to
0e9df21
Compare
ohodson
approved these changes
May 4, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The split2 module is downloaded over 13 million times per week and has over 1000 dependent modules. It is a good example of a simple utility that previously could not be run within workers without also bundling a complex and large polyfill of the streams API. Now, however, it can be run directly within a worker without any modifications and without any additional polyfills.