Tweaks for SQLite CPU limiting #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
May 3, 2023
kentonv
force-pushed
the
kenton/sqlite-interrupt
branch
from
bb3cce1 to
a70d75e
Compare
This avoids the need for a silly call to `IoContext::current()` inside the method implementation.
We will enforce CPU time limits separately.
kentonv
force-pushed
the
kenton/sqlite-interrupt
branch
from
a70d75e to
dfe0f92
Compare
a-robinson
approved these changes
May 3, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly implemented in the internal codebase. These are just a couple related tweaks.