Implement global origin property #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
May 9, 2023
jasnell
approved these changes
May 9, 2023
Changes the origin property from unimplemented to "null" following https://html.spec.whatwg.org/multipage/browsers.html#concept-origin-opaque. If origin is unimplemented, then it causes an exception to be thrown when the inspector queries the origin property, and this subsequently trips checks in v8 that cause process termination. Test: Manual with inspector attached
ohodson
force-pushed
the
orion/global-origin
branch
from
9e21475 to
b12b7da
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the origin property from unimplemented to undefined. If origin is unimplemented, then it causes an exception to be thrown when the inspector queries the origin property, and this subsequently trips checks in v8 that cause process termination.