LOG_ERROR_PERIODICALLY() would not log in the first hour after system boot. #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-robinson
approved these changes
May 9, 2023
jasnell
approved these changes
May 9, 2023
Warfields
approved these changes
May 9, 2023
… boot. Since it uses the monotonic clock, the "origin" time is system boot time. So the first time LOG_ERROR_PERIODICALLY() runs, it thinks it last logged at system boot time, and it only logs again if it's been more than an hour since then. We'll just subtract an hour from the origin. Monotonic time is never negative so this should be sufficient.
kentonv
force-pushed
the
kenton/fix-log-error-periodic
branch
from
3f39259 to
226742b
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it uses the monotonic clock, the "origin" time is system boot time. So the first time LOG_ERROR_PERIODICALLY() runs, it thinks it last logged at system boot time, and it only logs again if it's been more than an hour since then.
We'll just subtract an hour from the origin. Monotonic time is never negative so this should be sufficient.