Add basic impl for Node.js KeyObject equals #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
approved these changes
May 10, 2023
|
There should be potential here to reduce duplication of the |
|
Yeah I'll be revisiting that later. Just not sure if the additional class and virtual method are worth it. |
Since we're using CryptoKey under the covers of KeyObject, we need to teach the various CryptoKey::Impl subclasses how to compare their contents.
jasnell
force-pushed
the
jsnell/nodejs-crypto-keyobject-equals
branch
from
ae2e45c to
af9fbc6
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're using CryptoKey under the covers of KeyObject, we need to teach the various CryptoKey::Impl subclasses how to compare their contents.