Soft fail if workerd npm postinstall script fails
#639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're planning to add `workerd` as a hard dependency of `wrangler`. If `workerd` fails to install, we'd still like the `wrangler` install to succeed, so they can use remote dev and the rest of the commands. This logs the error instead of throwing, allowing the `postinstall` to "succeed".
jasnell
approved these changes
May 11, 2023
penalosa
approved these changes
May 11, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're planning to add
workerdas a hard dependency ofwrangler. Ifworkerdfails to install, we'd still like thewranglerinstall to succeed, so users can use remote dev and the rest of the commands. This logs the error instead of throwing, allowing thepostinstallto "succeed".