Change delivery of websocket for hibernation event #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MellowYarker
commented
May 19, 2023
src/workerd/io/hibernation-manager.h
Outdated
| kj::Maybe<HibernatableWebSocket&> webSocketForEventHandler; | ||
| // Allows the HibernatableWebSocket event handler that is currently running to access the | ||
| // HibernatableWebSocket that it needs to execute. | ||
| const uint16_t EVENT_QUEUE_CAPACITY = 1024; |
There was a problem hiding this comment.
I don't know what a good value for this is, the previous assumption of 1 was too low, I feel like 1024 is pretty high but it I can imagine scenario's where we could go higher (you have 32k websockets that all message/close/whatever at once). It really depends on the latency between calling customEvent() and then actually running it.
bcaimano
approved these changes
May 22, 2023
MellowYarker
force-pushed
the
milan/hibernation-deliver-ws
branch
2 times, most recently
from
d2d285c to
a31bb99
Compare
We noticed the `webSocketForEventHandler` reference was being overwritten by subsequent events before an event that set it could read the value. To fix this, we use a map of `ID`s to `HibernatableWebSocket`s and pass the ID to the event itself so it can find its associated websocket.
|
Got nervous about potential lifetime issues so |
MellowYarker
force-pushed
the
milan/hibernation-deliver-ws
branch
from
c6ed1aa to
87ee94f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed the
webSocketForEventHandlerreference was being overwritten by subsequent events before an event that set it could read the value.To fix this, we use a map of
IDs toHibernatableWebSockets and pass the ID to the event itself so it can find its associated websocket.