Handling explicit null bindings in SQLite #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
May 22, 2023
kentonv
reviewed
May 23, 2023
These were being implicitly coerced into a string before reaching the `SqliteDatabase::Query::bind` function. I've also added tests to confirm that you can inject BLOBs by binding a `Uint8Array` Update src/workerd/api/sql.c++ Co-authored-by: Kenton Varda <kenton@cloudflare.com>
geelen
force-pushed
the
glen/sqlite-null-bindings
branch
from
56cf50d to
17c893f
Compare
kentonv
approved these changes
May 24, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were being implicitly coerced into a string before reaching the
SqliteDatabase::Query::bindfunction.I've also added tests to confirm that you can inject BLOBs by binding a
Uint8Array