Review comments from V8 11.4.183.12 update (#678) #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohodson
force-pushed
the
orion/v8-11.4-review-comments
branch
from
1527fcf to
7657909
Compare
Incorporates review comments in #678 relating to v8-updates.md: * Patches should be generated with --full-index * Adds a note about shallow-since Also includes some re-wording of v8-updates.md and regenerates V8 patches with --full-index. Bug: EW-7428 Test: bazel build //...
ohodson
force-pushed
the
orion/v8-11.4-review-comments
branch
from
7657909 to
4bd41fd
Compare
harrishancock
approved these changes
May 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates review comments in #678
Review comments from #678
Bug: EW-7428
Test: bazel build //...