Drastically reduce Windows build log size #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
changed the title
jasnell
approved these changes
May 25, 2023
fhanau
force-pushed
the
felix/windows-debloat
branch
from
bdb8dca to
715e9e6
Compare
fhanau
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows build log on CI is currently very large, ~12MB on a recent run with few changes compared to 400kb on Mac and Linux, which makes it more difficult to look at the build logs when tracking down Windows build failures on CI and is bad for the Windows DX.
This is caused largely by V8 needing the
-Wno-invalid-offsetofflag to not throw a ton of warnings. V8's bazel enables the flag when using a clang-based compiler, but it doesn't realize that the Windows build uses clang.Adding the warning reduces the build log to 1.1MB, likely even more on a regular build where the build settings don't change.
I'm not sure if this is the right place for the flag though – it might make more sense to integrate it into V8's build system through a patch.