fix undefined behavior during type wrapper initialization #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Jun 3, 2023
kentonv
approved these changes
Jun 4, 2023
casting this during constructor is ub because of vptr not completely initialiazed. introducing new explicit initialization step. performance should be the same, since this is just moving same code around
mikea
force-pushed
the
maizatskyi/2023-06-02-type-wrapper-ubsan
branch
from
eed093e to
233b67a
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
casting this during constructor is ub because of vptr not completely initialiazed. introducing new explicit initialization step. performance should be the same, since this is just moving same code around