Enable LLVM_SYMBOLIZER by default in tests #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
force-pushed
the
kenton/symbolizer
branch
from
628ba56 to
b164ba5
Compare
ohodson
approved these changes
Jun 5, 2023
jasnell
approved these changes
Jun 5, 2023
This is needed to get symbolized stacks in wd_tests. Since it is a no-op if LLVM_SYMBOLIZER is not defined, it shouldn't affect production uses.
kentonv
force-pushed
the
kenton/symbolizer
branch
from
b164ba5 to
e508634
Compare
|
Rebased to hopefully get CI fixes. I would still like to get @mikea's opinions on this change as he's the most familiar with how this code works. |
mikea
approved these changes
Jun 5, 2023
| ], | ||
| ] + select({ | ||
| "@platforms//os:windows": [], | ||
| "//conditions:default": ["@workerd//src/workerd/util:symbolizer"], |
There was a problem hiding this comment.
I always have it linked in when I work on things too.
kentonv
force-pushed
the
kenton/symbolizer
branch
from
e508634 to
0b1beb3
Compare
kentonv
force-pushed
the
kenton/symbolizer
branch
from
0b1beb3 to
2083709
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including in wd_tests, which requires linking into workerd.
This should make debugging a lot easier for people working on this repo.