Fix Windows compilation by enabling kj-brotli #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually this looks pretty difficult to fix. The brotli bazel build uses Edit: Created a modified copy of the brotli build file, that fixes it. |
fhanau
force-pushed
the
felix/windows-br-fix
branch
3 times, most recently
from
10f7d61 to
89d5980
Compare
jasnell
approved these changes
Jun 7, 2023
fhanau
force-pushed
the
felix/windows-br-fix
branch
from
89d5980 to
249f0e2
Compare
ohodson
approved these changes
Jun 7, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kj-brotli was only included in the build for unix platforms, which caused the Windows runner to fail. Not sure how this slipped through CI previously, all tests passed on the PR for this.
Edit: Looks like the
Build & Releasejob is what's failing, that's why it wasn't caught earlier