Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improves TCP Socket connection failure errors. #747

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Improves TCP Socket connection failure errors. #747

merged 1 commit into from
Jun 12, 2023

Conversation

dom96
Copy link
Collaborator

@dom96 dom96 commented Jun 7, 2023

Improve error messages returned due to TCP Socket connection failures.

Tested upstream.

irvinebroque
irvinebroque approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comment. Thank you for this! So helpful to make sure we give back good error messages.

src/workerd/api/sockets.c++ Outdated Show resolved Hide resolved
@dom96 dom96 force-pushed the dominik/EW-7501-2 branch from 752ac47 to 272497f Compare June 12, 2023 10:49
@dom96 dom96 merged commit d2db6cd into main Jun 12, 2023
@dom96 dom96 deleted the dominik/EW-7501-2 branch June 12, 2023 12:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@irvinebroque irvinebroque irvinebroque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dom96 @jasnell @irvinebroque