Implement EmbedderRootsHandler::TryResetRoot().
#756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In V8 11.5, things changed so that the `ResetRoot()` callback might be called on a background thread. A new method, `TryResetRoot()`, can be implemented to return false in order to prevent this and force `ResetRoot()` back to the main thread. However, its default implementation just calls `ResetRoot()` (on the background thread), hence the default behavior changed. https://chromium-review.googlesource.com/c/v8/v8/+/4474708 Our `ResetRoot()` must be called on the main thread, so we must implement `TryResetRoot()` to return false. This allows us to remove the `single_threaded_gc` flag we added recently as a work-around. It turns out that flag isn't actually sufficient to avoid the problem anyway.
harrishancock
approved these changes
Jun 9, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In V8 11.5, things changed so that the
ResetRoot()callback might be called on a background thread. A new method,TryResetRoot(), can be implemented to return false in order to prevent this and forceResetRoot()back to the main thread. However, its default implementation just callsResetRoot()(on the background thread), hence the default behavior changed.https://chromium-review.googlesource.com/c/v8/v8/+/4474708
Our
ResetRoot()must be called on the main thread, so we must implementTryResetRoot()to return false.This allows us to remove the
single_threaded_gcflag we added recently as a work-around. It turns out that flag isn't actually sufficient to avoid the problem anyway.