Moving D1 shim inside workerd #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geelen
force-pushed
the
d1-shim-in-workerd
branch
from
4cb30b4 to
6b0a399
Compare
geelen
force-pushed
the
d1-shim-in-workerd
branch
3 times, most recently
from
44696ba to
10dfc33
Compare
jasnell
reviewed
Jun 15, 2023
jasnell
approved these changes
Jun 15, 2023
geelen
force-pushed
the
d1-shim-in-workerd
branch
from
10dfc33 to
ce74b4f
Compare
jasnell
approved these changes
Jun 16, 2023
geelen
force-pushed
the
d1-shim-in-workerd
branch
from
ebb770c to
d5e77b3
Compare
…other worker stage WIP
geelen
force-pushed
the
d1-shim-in-workerd
branch
from
d5e77b3 to
cecca67
Compare
jacwright
reviewed
Jul 18, 2023
| run<T = unknown>(): Promise<D1Result<T>>; | ||
| all<T = unknown>(): Promise<D1Result<T>>; | ||
| all<T = unknown>(): Promise<D1Result<T[]>>; |
There was a problem hiding this comment.
This is causing issues. D1Result has the property results: T[]; putting T as an array. This change is saying all() returns an array of arrays as the result. This needs to be reverted, or D1Result needs to be updated to results: T; if run() doesn't return an array in results. But I think it is the former.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently trying out using the
wrappedbinding type to do this without any C++ changes, but difficult to do an e2e test...