Rename QueueMessage type parameter
#765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`QueueMessage` is renamed to `Message` in its override elsewhere, and the rename transform is not type parameter aware. To ensure the type parameter is still used, rename it to something that shouldn't be renamed. Fixes #758
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueueMessageis renamed toMessagein its override...workerd/src/workerd/api/queue.h
Line 133 in d073c09
...but the rename transform is not type parameter aware. To ensure the type parameter is still used, rename it to something that shouldn't be renamed.
Fixes #758