Add Node crypto.getHashes() and hash errors to prepare Hash support #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Jun 23, 2023
| // expected to change infrequently based of bssl's stability-focused approach. | ||
| return ['md4', 'md5', 'sha1', 'sha224', 'sha256', 'sha384', 'sha512', 'md5-sha1', 'RSA-MD5', | ||
| 'RSA-SHA1', 'RSA-SHA224', 'RSA-SHA256', 'RSA-SHA384', 'RSA-SHA512', 'DSA-SHA', | ||
| 'DSA-SHA1', 'ecdsa-with-SHA1']; |
There was a problem hiding this comment.
This is fine. Are these all of the hashes supported by boringssl or just a subset?
There was a problem hiding this comment.
Yes, this includes all hashes as listed in https://boringssl.googlesource.com/boringssl/+/fips-20210429/crypto/digest_extra/digest_extra.c#77. boringssl also includes a number of additional deprecated hashes but they are not supported by EVP_get_digestbyname and thus won't be useful in a node crypto context.
jasnell
approved these changes
Jun 23, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.