Noop for test GC pass when not in debug #792
Conversation
src/workerd/jsg/jsg.c++
Outdated
| @@ -194,12 +194,14 @@ void Lock::setLoggerCallback(kj::Function<Logger>&& logger) { | |||
| } | |||
|
|
|||
| void Lock::requestGcForTesting() const { | |||
| #ifdef KJ_DEBUG | |||
There was a problem hiding this comment.
It'd be better to do this in WorkerEntrypoint::maybeAddGcPassForTest(). Otherwise, there's still a bunch of extra work that happens there in predictable mode, in particular taking an isolate lock, which will slow down load tests for no reason.
To get accurate metrics when load testing an optimized build, the GC pass that is normally done per test is now disabled.
Warfields
force-pushed
the
swarfield/debug-mode-for-gc
branch
from
c0cdfe9 to
952080d
Compare
There was a problem hiding this comment.
Seems OK for the immediate need. At some point in the future, might be nice to plumb in a separate GC-after-test option, so that debug and release tests have more similar behavior. Also, not sure if asan tests are built in release mode or not, but being able to run those with or without GC might increase the chances of finding lifetime errors.
ASAN is not currently built in release. |
To get accurate metrics when load testing an optimized build, the GC pass that is normally done per test is now disabled.