Fix ECDH key import when strict_crypto_checks is enabled #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
force-pushed
the
felix/ecdh-flag-fix
branch
from
dab4e8d to
84c2b96
Compare
jasnell
approved these changes
Jun 23, 2023
With the `strict_crypto_checks` flag enabled, imported ECDH keys were required to have empty usages, but for private keys the usage set should be allowed to include deriveBits and deriveKey. Since the compatibility date for the flag has not yet passed, this is unlikely to have had a significant effect.
fhanau
force-pushed
the
felix/ecdh-flag-fix
branch
from
84c2b96 to
ef79b40
Compare
nhynes
pushed a commit
to escrin/workerd
that referenced
this pull request
Jun 26, 2023
) With the `strict_crypto_checks` flag enabled, imported ECDH keys were required to have empty usages, but for private keys the usage set should be allowed to include deriveBits and deriveKey. Since the compatibility date for the flag has not yet passed, this is unlikely to have had a significant effect.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
strict_crypto_checksflag enabled, imported ECDH keys were required to have empty usages, but for private keys the usage set should be allowed to include deriveBits and deriveKey.Since the compatibility date for the flag has not yet passed, this is unlikely to have had a significant effect.
Also updates a compat flag description to clarify that the public exponent is limited to a certain set of values.