Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[nfc] extracting rust pacakge definitions to packages.bzl #863

Merged
merged 1 commit into from
Jul 14, 2023
Merged

[nfc] extracting rust pacakge definitions to packages.bzl #863

merged 1 commit into from
Jul 14, 2023

Conversation

mikea
Copy link
Collaborator

@mikea mikea commented Jul 13, 2023

the intent is to reuse RTTI_PACKAGES in edgeworker to enable /tools/... compilation on CI.

@mikea
[nfc] extracting rust pacakge definitions to packages.bzl
0259a78 
the intent is to reuse RTTI_PACKAGES in edgeworker to
enable /tools/... compilation on CI.
@mikea mikea requested review from ohodson and fhanau July 13, 2023 23:00
fhanau
fhanau approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@fhanau fhanau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Does bazel require PACKAGES to live in a separate file or do you just think it's just cleaner to have two files here?

@mikea
Copy link
Collaborator Author

mikea commented Jul 13, 2023

LGTM overall. Does bazel require PACKAGES to live in a separate file or do you just think it's just cleaner to have two files here?

you can only load .bzl files. You can't export a variables from BUILD files afaik.

@fhanau
Copy link
Collaborator

fhanau commented Jul 13, 2023

you can only load .bzl files. You can't export a variables from BUILD files afaik.

Ok, makes sense.

@mikea mikea merged commit bbb26a7 into main Jul 14, 2023
@mikea mikea deleted the maizatskyi/2023-07-13-rust-packages branch July 14, 2023 20:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ohodson ohodson ohodson approved these changes

@fhanau fhanau fhanau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikea @fhanau @ohodson