Coroutines Conversion: convert Blob::BlobInputStream #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
reviewed
Jul 14, 2023
jasnell
force-pushed
the
jsnell/coroutines-conversion-blobinputstream
branch
from
2c8458f to
c466815
Compare
jasnell
force-pushed
the
jsnell/coroutines-conversion-blobinputstream
branch
from
c466815 to
1160fb2
Compare
* Add function comments/documentation * Avoid unnecessary memcpy and slice when tryRead amount is 0
kentonv
approved these changes
Jul 17, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the effort to begin broader adoption of coroutines across the codebase, I plan to open a number of small examplar PRs as part of the preparation for the larger effort to devise and document a plan for the larger effort. This is largely intended to help tease out whether there are any particularly thorny issues that may be uncovered while we go through the process, but also to provide examples for the team on how the conversion can be done.
This PR picks one small API largely at random (Blob::BlobInputStream) that is easy to convert.
And since I'm in the code, I'm also taking the opportunity to do a bit of Drive By cleanup, documentation, and minor refactoring to simplify impl along the way.