Coroutines Conversion: Migrate streams compression to coroutines #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflansburg
force-pushed
the
kflansburg/coroutines-compression
branch
from
4ec20c1 to
e55be85
Compare
kentonv
reviewed
Jul 14, 2023
Co-authored-by: Kenton Varda <kenton@cloudflare.com>
jasnell
reviewed
Jul 16, 2023
jasnell
approved these changes
Jul 16, 2023
Co-authored-by: James M Snell <jsnell@cloudflare.com>
jasnell
changed the title
mikea
approved these changes
Jul 17, 2023
| }); | ||
| if (pieces.size() != 0) { | ||
| co_await write(pieces[0].begin(), pieces[0].size()); | ||
| co_await write(pieces.slice(1, pieces.size())); |
There was a problem hiding this comment.
I'm late to the review, but want to point out that this conversion inhibits tail-call optimization. If pieces is sufficiently large, this could theoretically cause a stack overflow.
To avoid this problem, this recursive write() function would need to be refactored into a for loop.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.