Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🐛 BUG: VSCode debugger doesn't work on Wrangler 3.19 and up #5297

Closed
wikes82 opened this issue Mar 19, 2024 · 7 comments · Fixed by #6424
Closed

🐛 BUG: VSCode debugger doesn't work on Wrangler 3.19 and up #5297

wikes82 opened this issue Mar 19, 2024 · 7 comments · Fixed by #6424
Labels
bug Something that isn't working

Comments

@wikes82
Copy link

wikes82 commented Mar 19, 2024

Which Cloudflare product(s) does this pertain to?

Wrangler core

What version(s) of the tool(s) are you using?

Wrangler 3.19.0

What version of Node are you using?

20.11.1

What operating system and version are you using?

Windows

Describe the Bug

Observed behavior

VSCode debug doesn't work anymore since Wrangler 3.19
The breakpoint is hit, but it continue executing instead of pausing the execution.

Expected behavior

Make VSCode debug work again.

Steps to reproduce

Please provide the following:

Please provide a link to a minimal reproduction

No response

Please provide any relevant error logs

No response

@wikes82 wikes82 added the bug Something that isn't working label Mar 19, 2024
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 19, 2024
@ad6025b
Copy link

ad6025b commented Apr 20, 2024

@mrbbot @can someone please look at this? the vscode step debugger has been broken since >3.19

@mrbbot
Copy link
Contributor

mrbbot commented Apr 21, 2024

/cc @admah

@wikes82
Copy link
Author

wikes82 commented Apr 22, 2024

Just an update, on my original submission only tested on Windows.
I have tested on Linux and macOS as well, and it's also broken.

@ad6025b
Copy link

ad6025b commented May 21, 2024

@mrbbot @admah this refactoring https://github.com/cloudflare/workers-sdk/releases/tag/wrangler%403.19.0

==> this is the commit that broke the vscode step debugger
==> this commit: 29df8e1

image

@ad6025b
Copy link

ad6025b commented May 21, 2024

@mrbbot @admah Ok, i narrowed to the same reported problem here:
==> this is the issue: cloudflare/workerd#2051

the only workaround is to downgrade to v3.18. (3.19 and above is all broken)

running the command [ npx wrangler dev --log-level debug ]
you can see the error:

workerd/jsg/util.c++:291: error: e = kj/compat/http.c++:5754: failed: WebSocket protocol error; protocolError.statusCode = 1009; protocolError.description = Message is too large: 4670082 > 1048576

image


other people have report same problem here on discord:
https://discord.com/channels/595317990191398933/799437470004412476/1219640695296360513

image

@kyle-pena-nlp
Copy link

Hey devs - you kind of need to fix this. The debugger doesn't work for codebases over a certain (but still reasonable size). That means any of the work you've done past 3.18 isn't usable to anybody who needs a debugger. Please prioritize accordingly.

@RamIdeas
Copy link
Contributor

We have a fix in-progress for this in workerd cloudflare/workerd#2164

Once that lands, we will make wrangler set that flag when running workerd, which should fix this issue

@RamIdeas RamIdeas moved this from Untriaged to In Progress in workers-sdk Jun 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in workers-sdk Aug 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something that isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants