Add a compat flag for increasing the WS message size limit #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
May 24, 2024
penalosa
force-pushed
the
penalosa/increase-ws-size
branch
from
5c85dd3 to
25ef42e
Compare
jasnell
approved these changes
May 24, 2024
kentonv
reviewed
May 24, 2024
kentonv
reviewed
May 24, 2024
src/workerd/api/web-socket.h
Outdated
| @@ -425,6 +425,9 @@ class WebSocket: public EventTarget { | |||
| // `close()`, thereby preventing calls to `send()` even after we wake from hibernation. | |||
| bool closedOutgoingForHib = false; | |||
|
|
|||
| // Maximum allowed size for WebSocket messages | |||
| size_t maxMessageSize = 1u << 20; | |||
There was a problem hiding this comment.
Use the constant kj::WebSocket::SUGGESTED_MAX_MESSAGE_SIZE.
kentonv
reviewed
May 24, 2024
src/workerd/api/web-socket.h
Outdated
| @@ -425,6 +425,9 @@ class WebSocket: public EventTarget { | |||
| // `close()`, thereby preventing calls to `send()` even after we wake from hibernation. | |||
| bool closedOutgoingForHib = false; | |||
|
|
|||
| // Maximum allowed size for WebSocket messages | |||
| size_t maxMessageSize = 1u << 20; | |||
There was a problem hiding this comment.
Instead of having this be a member of WebSocket, could you pass it as a parameter to readLoop() (reading the feature flag in startReadLoop())?
|
Probably related: cloudflare/workers-sdk#6219 |
RamIdeas
force-pushed
the
penalosa/increase-ws-size
branch
from
998d373 to
e1fcf20
Compare
13 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one step towards addressing #2051 (Wrangler changes will also be needed)