-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Change dev registry and inspector server to use 127.0.0.1 instead of all interfaces #4437
Conversation
🦋 Changeset detectedLatest commit: ba1f074 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6868977660/npm-package-wrangler-4437 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6868977660/npm-package-wrangler-4437 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6868977660/npm-package-wrangler-4437 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6868977660/npm-package-miniflare-4437 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6868977660/npm-package-cloudflare-pages-shared-4437 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
0b79b3b
to
9b181b4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4437 +/- ##
==========================================
+ Coverage 75.46% 75.50% +0.03%
==========================================
Files 225 225
Lines 12478 12478
Branches 3239 3239
==========================================
+ Hits 9417 9421 +4
+ Misses 3061 3057 -4
|
9b181b4
to
ea22145
Compare
c972768
to
937cdca
Compare
937cdca
to
ba1f074
Compare
Fixes #4430
The dev registry and inspector server listen on all interfaces when running
wrangler dev
, this might not be desired by users who use--ip
to prevent listening beyondlocalhost
. This PR will will make the dev registry and inspector server use127.0.0.1
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.