Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add validation to binding name input in vscode extension #7600

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Dec 19, 2024

validates that binding names are unique and not empty
fixes DEVX-1547


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: difficult to test vscode ui and getting binding logic is directly copied from wrangler, where it is tested
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no e2e tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: unreleased

@emily-shen emily-shen requested a review from a team as a code owner December 19, 2024 18:18
Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 4ded91c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cloudflare-workers-bindings-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emily-shen emily-shen force-pushed the emily/vscode-validate-binding-name branch from dce3007 to 23a5d0d Compare December 19, 2024 18:19
Copy link
Contributor

github-actions bot commented Dec 19, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12419830273/npm-package-wrangler-7600

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7600/npm-package-wrangler-7600

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12419830273/npm-package-wrangler-7600 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12419830273/npm-package-cloudflare-workers-bindings-extension-7600 -O ./cloudflare-workers-bindings-extension.0.0.0-v96ff7aa08.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v96ff7aa08.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12419830273/npm-package-create-cloudflare-7600 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12419830273/npm-package-cloudflare-kv-asset-handler-7600
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12419830273/npm-package-miniflare-7600
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12419830273/npm-package-cloudflare-pages-shared-7600
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12419830273/npm-package-cloudflare-unenv-preset-7600
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12419830273/npm-package-cloudflare-vitest-pool-workers-7600
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12419830273/npm-package-cloudflare-workers-editor-shared-7600
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12419830273/npm-package-cloudflare-workers-shared-7600
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12419830273/npm-package-cloudflare-workflows-shared-7600

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.99.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241218.0 1.20241218.0
workerd --version 1.20241218.0 2024-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa force-pushed the emily/vscode-validate-binding-name branch from 23a5d0d to 2561f2d Compare December 19, 2024 19:50
@penalosa penalosa force-pushed the emily/vscode-validate-binding-name branch from cffe4a2 to 4ded91c Compare December 19, 2024 19:55
@penalosa
Copy link
Contributor

For posterity, I manually tested this locally:
Screenshot 2024-12-19 at 19 58 03

@penalosa penalosa merged commit e3791f7 into main Dec 19, 2024
29 checks passed
@penalosa penalosa deleted the emily/vscode-validate-binding-name branch December 19, 2024 20:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants