fix: Set goversion in app manifests to Go 1.21 #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the manifests for all the apps that use the Go buildpack to include `GOVERSION: go1.21`, which lets the buildpack know to build/run the apps with go1.21. Also inits a go module for `assets/multi-port-app`, which necessitates a package name change.
Doesn't print out the envValues unless the test fails.
Clones the http.DefaultTransport rather than starting from blank, as the default struct includes some useful defaults.
ctlong
approved these changes
Jan 29, 2024
This was referenced Jan 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
Yes
What is this change about?
Specifying Go version in the assets manifests so that apps are deployed with Go 1.21.
Please provide contextual information.
None
What version of cf-deployment have you run this cf-acceptance-test change against?
v33.4.0
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
None
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@ctlong