Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Deployment tests #1268

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

Samze
Copy link
Contributor

@Samze Samze commented Oct 9, 2024

Are you submitting this PR against the develop branch?

Yes

What is this change about?

  • Refactor existing Deployments tests so Rolling deployments use the CLI instead of the API
  • Add tests for Canary deployments
  • Add tests for max-in-flight

What version of cf-deployment have you run this cf-acceptance-test change against?

v42.2.0

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

How many more (or fewer) seconds of runtime will this change introduce to CATs?

More deployment tests, so more time!

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

@Samze Samze force-pushed the deployment_tests branch 2 times, most recently from fb2dae3 to 57072e1 Compare October 9, 2024 19:57
* Use the CLI for Rolling deployments
* Add tests for Canary deployments
* Add tests for max-in-flight
@Samze Samze force-pushed the deployment_tests branch from 57072e1 to ee2e294 Compare October 9, 2024 20:41
@Samze Samze marked this pull request as ready for review October 9, 2024 21:01
Copy link
Member

@davewalter davewalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davewalter davewalter merged commit 1e61fab into cloudfoundry:develop Oct 10, 2024
3 checks passed
@Samze Samze deleted the deployment_tests branch October 10, 2024 16:47
@Samze
Copy link
Contributor Author

Samze commented Oct 10, 2024

Thanks for the speedy review all 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants