fix(zipkin): increase app readiness timeout to reduce test flakes #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Closed
ctlong
changed the title
Increase readiness timeout to give the Spring Sleuth asset more time to startup, we've seen this `cf push` result in frequent flake due to readiness timeouts.
ctlong
force-pushed
the
fix/zipkin-tests
branch
from
ded5dc4 to
e98f984
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
What is this change about?
Increase readiness timeout for Spring Sleuth app in Zipkin Tracking tests. This should hopefully reduce test flakes in this suite.
Also refactors the zipkin tests, just cause.
Please provide contextual information.
#862
What version of cf-deployment have you run this cf-acceptance-test change against?
v29.1.0
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
None
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
None