Adding v3 deployments endpoint #931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding missing versions Adding missing response fields
|
✅ Hey AlbertoImpl! The commit authors and yourself have already signed the CLA. |
Albertoimpl
force-pushed
the
v3-deployments
branch
from
35301e1
to
7306327
Compare
The property was added a long time ago but it wasn't documented cloudfoundry/cloud_controller_ng#1273
Albertoimpl
force-pushed
the
v3-deployments
branch
from
7306327
to
e0197ee
Compare
twoseat
suggested changes
Dec 18, 2018
| @@ -32,6 +32,12 @@ | |||
|
|
|||
| PCF_2_1(Version.forIntegers(2, 102, 0)), | |||
|
|
|||
| PCF_2_2(Version.forIntegers(2, 112, 0)), | |||
|
|
|||
| PCF_2_3(Version.forIntegers(2, 120, 0)), | |||
There was a problem hiding this comment.
We don't typically add these until they're needed
There was a problem hiding this comment.
PCF_2_4 was needed for DeploymentsTest
Should I delete the previous ones just because they are not used?
...r/src/test/java/org/cloudfoundry/reactor/client/v3/deployments/ReactorDeploymentsV3Test.java
Show resolved
Hide resolved
cloudfoundry-client/src/main/java/org/cloudfoundry/client/v3/deployments/Deployment.java
Outdated
Show resolved
Hide resolved
cloudfoundry-client/src/main/java/org/cloudfoundry/client/v3/deployments/DeploymentsV3.java
Outdated
Show resolved
Hide resolved
cloudfoundry-client/src/main/java/org/cloudfoundry/client/v3/deployments/DeploymentsV3.java
Show resolved
Hide resolved
...actor/src/main/java/org/cloudfoundry/reactor/client/v3/deployments/ReactorDeploymentsV3.java
Outdated
Show resolved
Hide resolved
integration-test/src/test/java/org/cloudfoundry/client/v3/DeploymentsTest.java
Outdated
Show resolved
Hide resolved
twoseat
suggested changes
Dec 18, 2018
|
It actually works, I was able to do a tiny demo with updating a package with zero downtime thanks to this endpoint in PCF 2.4. Thanks! |
Cosmetic changes
This commit brings the client into line with version 2.125.0 of the Cloud Controller API.
Adding missing versions Adding missing response fields
The property was added a long time ago but it wasn't documented cloudfoundry/cloud_controller_ng#1273
Cosmetic changes
|
Merged in 9de4a51 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing versions
Adding missing response fields