Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Close responsestream #84

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Close responsestream #84

merged 1 commit into from
Jul 18, 2017

Conversation

elevenfive
Copy link
Contributor

@elevenfive elevenfive commented May 11, 2017

Avoids memory leak

E/StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
                                                                                  java.lang.Throwable: Explicit termination method 'end' not called
java.lang.Throwable: Explicit termination method 'end' not called
  at dalvik.system.CloseGuard.open(CloseGuard.java:180)
  at java.util.zip.Inflater.<init>(Inflater.java:104)
  at com.android.okhttp.okio.GzipSource.<init>(GzipSource.java:62)
  at com.android.okhttp.internal.http.HttpEngine.unzip(HttpEngine.java:645)
  at com.android.okhttp.internal.http.HttpEngine.readResponse(HttpEngine.java:821)
  at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:463)
  at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:405)
  at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponseCode(HttpURLConnectionImpl.java:521)
  at com.android.okhttp.internal.huc.DelegatingHttpsURLConnection.getResponseCode(DelegatingHttpsURLConnection.java:105)
  at com.android.okhttp.internal.huc.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java)
  at com.cloudinary.android.UploaderStrategy.callApi(UploaderStrategy.java:105)
  at com.cloudinary.Uploader.callApi(Uploader.java:34)
  at com.cloudinary.Uploader.upload(Uploader.java:76)
  at com.cloudinary.Uploader.upload(Uploader.java:68)
  at com.crewapp.android.crew.data.MediaUploader$2.run(MediaUploader.java:192)
  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
  at java.lang.Thread.run(Thread.java:761)

@elevenfive
Copy link
Contributor Author

@roeeba I think there is a problem with the build setup (logs mention missing cloud_name), any ideas?

@tocker tocker merged commit 70247c5 into cloudinary:master Jul 18, 2017
@tocker
Copy link
Contributor

tocker commented Jul 18, 2017

@elevenfive Thanks for the pull request!
Regarding the CI build - credentials are only passed to the test run when the branch originated from the same repository. That's why your tests failed.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants