Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add support for quality_analysis #171

Closed
bobmoff opened this issue Nov 22, 2017 · 3 comments · May be fixed by ironhack-course/lab-profile-app#2 or civilizador/TripleTrip#3
Closed

add support for quality_analysis #171

bobmoff opened this issue Nov 22, 2017 · 3 comments · May be fixed by ironhack-course/lab-profile-app#2 or civilizador/TripleTrip#3
Assignees

Comments

@bobmoff
Copy link

bobmoff commented Nov 22, 2017

wouldn't it be better just pass the options parameter on without modifying it?

then every new feature that is accessed using options would automatically be supported

@roeeba roeeba self-assigned this Nov 30, 2017
@roeeba
Copy link
Collaborator

roeeba commented Nov 30, 2017

Hi @bobmoff. Not entirely sure what you're trying to achieve? Are you asking if the 'quality_analysis' feature can be set by default? if so, this is not supported at the moment.

@bobmoff
Copy link
Author

bobmoff commented Nov 30, 2017

I couldn't get the quality analysis to work at all and I check the code and it looks like it is never accepted as option when uploading.

I switched to using a preset which has the quality analysis option added, and that way it worked.

Am i wrong? Is it supposed to work by just sending quality_analysis: true as an option ?

I am using the streaming upload.

@roeeba
Copy link
Collaborator

roeeba commented Dec 5, 2017

Hi @bobmoff. I apologize for the delayed reply. It seems that the quality_analysis feature wasn't added to the SDK yet. We will update as soon as it does.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
3 participants