Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: use SecurityGroupIds instad of SecurityGroupId for ProvisionGroup #157

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Vacant2333
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

remove the todo, the bug is fixed by alibabacloud

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Signed-off-by: Vacant2333 <vacant2333@gmail.com>
Copy link

gitautomator bot commented Dec 2, 2024

Thanks to your contribution, the maintainers will review it as soon as they can!

@jwcesign
Copy link
Contributor

jwcesign commented Dec 2, 2024

cc @daimaxiaxie @helen-frank

Copy link
Contributor

@jwcesign jwcesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@helen-frank helen-frank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jwcesign jwcesign merged commit 9d0df18 into cloudpilot-ai:main Dec 3, 2024
1 check passed
@jwcesign
Copy link
Contributor

/cherry-pick release-0.1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants