Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: fallback to OnDemand when Spot is not available #172

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

Vacant2333
Copy link
Contributor

@Vacant2333 Vacant2333 commented Dec 30, 2024

fix the cache.isUnavailable func

This issue may result in continuous retries to create the same Spot Instance

fix #167

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Copy link

gitautomator bot commented Dec 30, 2024

Thanks to your contribution, the maintainers will review it as soon as they can!

Copy link
Contributor

@helen-frank helen-frank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Vacant2333 Vacant2333 marked this pull request as ready for review December 30, 2024 16:22
@Vacant2333
Copy link
Contributor Author

the testing result:
image
image

@Vacant2333 Vacant2333 changed the title fix: the isUnavailable should't check CapacityType fix: fallback to OnDemand when Spot is not available Dec 31, 2024
@jwcesign
Copy link
Contributor

other lgtm

Leave approve to @daimaxiaxie

Signed-off-by: Vacant2333 <vacant2333@gmail.com>
@daimaxiaxie
Copy link
Contributor

/lgtm

@jwcesign jwcesign merged commit 7898a13 into cloudpilot-ai:main Dec 31, 2024
1 check passed
@jwcesign
Copy link
Contributor

/cherry-pick release-0.1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to escape NoStock error
4 participants