This repository was archived by the owner on Jan 31, 2021. It is now read-only.
Added ACM #3
Merged
Added ACM #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamsky
previously approved these changes
Mar 11, 2019
| @@ -28,7 +26,7 @@ module "subnets" { | |||
| } | |||
|
|
|||
| module "codefresh_backing_services" { | |||
| source = "git::https://github.com/cloudposse/terraform-aws-codefresh-backing-services.git?ref=0.1.0" | |||
There was a problem hiding this comment.
example easy to run based on the local directory.
tamsky
reviewed
Mar 11, 2019
acm.tf
Outdated
| } | ||
|
|
||
| module "acm_request_certificate" { | ||
| source = "git::https://github.com/cloudposse/terraform-aws-acm-request-certificate.git?ref=add/enabled-var" |
There was a problem hiding this comment.
ref=add/enabled-var => ref=tags/<release> ?
aknysh
reviewed
Mar 14, 2019
acm.tf
Outdated
|
|
||
| variable "acm_zone_name" { | ||
| type = "string" | ||
| default = "" |
There was a problem hiding this comment.
it probably needs to be a required param
aknysh
reviewed
Mar 14, 2019
acm.tf
Outdated
|
|
||
| output "acm_id" { | ||
| value = "${module.acm_request_certificate.id}" | ||
| description = "The ARN of the certificate" |
There was a problem hiding this comment.
Suggested change
| description = "The ARN of the certificate" | |
| description = "The ID of the certificate" |
Nuru
approved these changes
Mar 18, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why