Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use installed packages, segregate executables by platform #375

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Feb 2, 2024

what

why

  • After installing needed tools, the tools were not accessible
  • Ensure that tools installed for one platform do not clobber tools needed for a different platform
  • Dependency misspelled, breaking auto-readme

references

@Nuru Nuru requested a review from a team as a code owner February 2, 2024 08:51
@Nuru Nuru requested review from max-lobur, joe-niland and Benbentwo and removed request for goruha and aknysh February 2, 2024 08:52
@Nuru Nuru added bugfix Change that restores intended behavior and removed modules/readme modules/docs modules/packages labels Feb 2, 2024
joe-niland
joe-niland previously approved these changes Feb 2, 2024
Copy link
Member

@joe-niland joe-niland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it with Darwin/x86_64 and it seems to work well.

rm -rf $(PACKAGES_PATH); \
$(GIT) clone -c advice.detachedHead=false --depth=1 -b $(PACKAGES_VERSION) https://github.com/cloudposse/packages.git $(PACKAGES_PATH); \
rm -rf $(PACKAGES_PATH)/.git; \
$(GIT) clone -c advice.detachedHead=false --depth=1 -b $(PACKAGES_VERSION) https://github.com/cloudposse/packages.git "$(PACKAGES_PATH)"; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <erik@cloudposse.com>
@Nuru Nuru merged commit 743c047 into master Feb 2, 2024
11 of 12 checks passed
@Nuru Nuru deleted the use-installed-packages branch February 2, 2024 20:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants