Skip to content

fix: Make secretOptions optional #83

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 23, 2020
Merged

fix: Make secretOptions optional #83

merged 12 commits into from
Jun 23, 2020

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jun 16, 2020 •
edited
Loading

what

Make secretOptions optional so the same technique for mount_points is used for log_configuration

why

Currently the log_configuration has to be set to null otherwise upon an apply, you will see

Error: InvalidParameter: 1 validation error(s) found.
- missing required field, RegisterTaskDefinitionInput.ContainerDefinitions[2].LogConfiguration.LogDriver.

notes

It seems like I have to omit the type = map on the variable "log_configuration definition or the example will fail with a TERRAFORM CRASH

references

@nitrocode nitrocode requested review from osterman and aknysh June 16, 2020 19:31
@nitrocode nitrocode changed the title Make secretOptions optional fix: Make secretOptions optional Jun 16, 2020
@nitrocode
Copy link
Member Author

/rebuild-readme

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/terraform-fmt

@nitrocode
Copy link
Member Author

/test all

Gowiem
Gowiem reviewed Jun 16, 2020
View reviewed changes
@nitrocode
Copy link
Member Author

/test all

1 similar comment
@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/rebuild-readme

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode requested a review from Gowiem June 21, 2020 10:42
@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode merged commit 2155507 into master Jun 23, 2020
@nitrocode nitrocode deleted the secretoptions-optional branch June 23, 2020 19:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@osterman osterman osterman approved these changes

@aknysh aknysh Awaiting requested review from aknysh

@Gowiem Gowiem Awaiting requested review from Gowiem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log_configuration shouldn't require optional key secretOptions
4 participants
@nitrocode @osterman @Gowiem @actions-bot